Remove unnecessary asNumber logic #1191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianBuzzo
force-pushed
the
674-number-handling
branch
6 times, most recently
from
5913047
to
2534751
Compare
|
This looks like it got a bad merge somehow? I think you just intended to include the last commit. |
|
@epicfaace Can you rebase this PR on top of master please? |
epicfaace
force-pushed
the
674-number-handling-simplify
branch
from
6e2586a
to
561dff1
Compare
|
@LucianBuzzo done! |
epicfaace
commented
Dec 16, 2019
| @@ -1152,12 +1152,11 @@ describe("utils", () => { | |||
| }); | |||
|
|
|||
| it("should return the raw value if the input ends with a dot", () => { | |||
There was a problem hiding this comment.
Suggested change
| it("should return the raw value if the input ends with a dot", () => { | |
| it("should convert the value to an integer if the input ends with a dot", () => { |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for PR #1183. I believe we don't need this logic anymore, with the changes implemented in the aforementioned PR.