Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support readOnly property from latest validation draft #1282

Merged
merged 4 commits into from
May 14, 2019
Merged

Support readOnly property from latest validation draft #1282

merged 4 commits into from
May 14, 2019

Conversation

pahen
Copy link
Contributor

@pahen pahen commented May 13, 2019

Reasons for making this change

Since the readOnly property now is available in the latest validation draft (previously it was in hyper schema only), it makes sense to use this property to signal read only for fields.

Fixes #976
Replaces PR #888

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@pahen pahen changed the title Read only Support readOnly property from latest validation draft May 13, 2019
src/components/fields/SchemaField.js Outdated Show resolved Hide resolved
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@epicfaace epicfaace merged commit 98952b7 into rjsf-team:master May 14, 2019
@pahen
Copy link
Contributor Author

pahen commented May 14, 2019

Would it be possible to have a new release with this included soon?

@pahen
Copy link
Contributor Author

pahen commented Jun 5, 2019

Is there any plan for a new release soon @epicfaace? I really need this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't work "readOnly" attribute from Schema
3 participants