Take into account implicitly defined types when rendering labels for fields #2502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSchemaType
is clever enough to figure out that a schema withproperties
oradditionalProperties
hastype
"object", even if thetype is not explicitly defined, but
getDisplayLabel
does not have thesame logic, which results in displaying the label twice in cases where
the schema was guessed to be object.
Using
getSchemaType
as well ingetDisplayLabel
bring consistentbehavior and the label is rendered only once in that case.
Reasons for making this change
fixes #2501
Checklist