Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mui joy integration #4021

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

dj-fiorex
Copy link

Add support for Mui-Joy UI

This PR add support for the UI library MUI-JOY, with a new package @rjsf/mui-joy
All components are functional and playground works as expected.

90% tests are passing but i need some help because i don't know how to solve other tests from failing. This is because the tests are failing when comparing some html that is different because mui joy add ids ecc. ecc. "at runtime", i think.

i did not updated the CHANGELOG yet.

return Object.values(state).every((value) => value !== -1);
}

function dateElementProps(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4004 implements a function to replace these. Once it is merged can you update this. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i will update when it willl be merged

packages/mui-joy/src/AltDateWidget/AltDateWidget.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/AltDateWidget/AltDateWidget.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/SelectWidget/SelectWidget.tsx Outdated Show resolved Hide resolved
packages/playground/package.json Show resolved Hide resolved
packages/playground/src/components/DemoFrame.tsx Outdated Show resolved Hide resolved
@heath-freenome
Copy link
Member

heath-freenome commented Jan 11, 2024

@dj-fiorex the utility function is now available. Also can you resolve the conflicts

@dj-fiorex
Copy link
Author

Perfect, i will update and make another commit

@heath-freenome
Copy link
Member

Perfect, i will update and make another commit

@dj-fiorex You will need to resolve conflicts in the MR. Also, if the tests are different due to html changes, you should be able to refresh them via npm run test:update

@JohnValanidas
Copy link

What is left to get this merged? I don't mind taking the extra work on if it's pretty straightforward. I'd really like to be able to use mui-joy in one of my projects right now.

@heath-freenome
Copy link
Member

heath-freenome commented Apr 30, 2024

What is left to get this merged? I don't mind taking the extra work on if it's pretty straightforward. I'd really like to be able to use mui-joy in one of my projects right now.

@JohnValanidas A rebase to main, resolving conflicts; Updating AltDateWidget to use the function provided in #4004; updating tests if necessary;

@JohnValanidas
Copy link

@heath-freenome Awesome. I'll see what I can do as soon as I get some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants