Omit extra data in schemaUtils #4139

MarekBodingerBA · 2024-03-22T18:14:28Z

Reasons for making this change

For now I implemented the draft version (code and markdown documentation is not finished yet). Would you be able to look if everything seems alright with the progress so far?

Checklist

I'm updating documentation
- I've checked the rendering of the Markdown text I've added
I'm adding or updating code
- I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
- I've updated docs if needed
- I've updated the changelog with a description of the PR
I'm adding a new feature
- I've updated the playground with an example use of the feature

heath-freenome

Looks like your tests are failing

heath-freenome · 2024-03-22T19:09:03Z

packages/utils/src/schema/omitExtraData.ts

+import _pick from 'lodash/pick';
+
+import _get from 'lodash/get';
+import _isEmpty from 'lodash/isEmpty';
+import toPathSchema from './toPathSchema';


Suggested change

import _pick from 'lodash/pick';

import _get from 'lodash/get';

import _isEmpty from 'lodash/isEmpty';

import toPathSchema from './toPathSchema';

import _pick from 'lodash/pick';

import _get from 'lodash/get';

import _isEmpty from 'lodash/isEmpty';

import toPathSchema from './toPathSchema';

packages/utils/src/schema/omitExtraData.ts

heath-freenome · 2024-03-22T19:09:41Z

packages/utils/src/schema/omitExtraData.ts

+ return data as T;
+}
+
+export default function omitExtraData<


Consider adding JSDoc

packages/utils/src/types.ts

packages/utils/src/createSchemaUtils.ts

- getFieldNames tests are taken from Form.test.jsx and modified - getUsedFormData tests are taken from Form.test.jsx and modified, originally they contained schemas that weren't necessary - some extra tests for omitExtraData are created

…ata, remove moved tests, fix relevant tests

heath-freenome · 2024-04-01T17:58:07Z

@MarekBodingerBA There is one failing tests, and you also have to get the test coverage back up to 100% given the new code you wrote

MarekBodingerBA · 2024-04-01T18:04:31Z

@MarekBodingerBA There is one failing tests, and you also have to get the test coverage back up to 100% given the new code you wrote

Of course, I am still working on it, it's a draft afterall . :)

heath-freenome · 2024-04-01T18:26:23Z

@MarekBodingerBA There is one failing tests, and you also have to get the test coverage back up to 100% given the new code you wrote

Of course, I am still working on it, it's a draft afterall . :)

Awesome! how do you feel it is going? Are you needing any help?

MarekBodingerBA · 2024-04-02T10:48:48Z

@MarekBodingerBA There is one failing tests, and you also have to get the test coverage back up to 100% given the new code you wrote

Of course, I am still working on it, it's a draft afterall . :)

Awesome! how do you feel it is going? Are you needing any help?

Actually, the failing test is a bug in the original code that I've only migrated and created a test that found this.

I would probably like to disable the test and create a separate issue for this (as there would be no regression). The thing is, that I find getFieldNames implementation a bit overblown (and buggy in this case) for what it does, but I think it is better do to in a separate issue and don't mix those two together.

heath-freenome · 2024-04-05T17:26:12Z

@MarekBodingerBA There is one failing tests, and you also have to get the test coverage back up to 100% given the new code you wrote

Of course, I am still working on it, it's a draft afterall . :)

Awesome! how do you feel it is going? Are you needing any help?

Actually, the failing test is a bug in the original code that I've only migrated and created a test that found this.

I would probably like to disable the test and create a separate issue for this (as there would be no regression). The thing is, that I find getFieldNames implementation a bit overblown (and buggy in this case) for what it does, but I think it is better do to in a separate issue and don't mix those two together.

That is fine, as long as we get that bug fixed soon after we merge this

heath-freenome · 2024-05-10T19:43:43Z

@MarekBodingerBA How is this work going? There seem to be several new issues related to this feature and I would love to get this part refactored

heath-freenome · 2024-07-01T22:02:05Z

@MarekBodinger FYI, I just merged a PR that will definitely force you to deal with the conflicts. How can I support you in getting this code merged?

MarekBodingerBA · 2024-07-02T10:16:45Z

Hi @heath-freenome,

sorry for not responding. I've got stuck with this pull request.

As far as I remember, it seems that in some cases the schema must be retrieved (as it always is in Form component where the original code) is. When I migrated the standalone implementation it started to fail for pretty ordinary schemas (as you can see in the test case). Then I started to digging into getFieldNames and I realized the best would be to completely rewrite the function, but wasn't really sure how to proceed with this safely.

Merge the code please, I am curious what's new. I would like to proceed in future with this, but don't have a capacity to do so now.

heath-freenome · 2024-07-02T16:18:17Z

@MarekBodingerBA I can't quite merge the code as there are conflicts. Would you be willing to resolve them and comment out the one failing test. Then we can write an issue to deal with fixing the test and the bug associated with it. Also, a change was recently made to Form which is probably the source of the conflicts and you may need to fiddle with the code some to resolve them correctly.

heath-freenome reviewed Mar 22, 2024

View reviewed changes

heath-freenome mentioned this pull request Mar 22, 2024

Cannot change property value with liveOmit and omitExtraData for arrays of objects and conditionality #4109

Closed

4 tasks

MarekBodinger added 4 commits March 29, 2024 12:08

Extract omitExtraData functionality from Form.tsx (core) to utils

1efd306

Create tests for omitExtraData:

0d2e85a

- getFieldNames tests are taken from Form.test.jsx and modified - getUsedFormData tests are taken from Form.test.jsx and modified, originally they contained schemas that weren't necessary - some extra tests for omitExtraData are created

Replace getFieldNames and getUsedFormData with schemaUtils.omitExtraD…

2811a66

…ata, remove moved tests, fix relevant tests

Add documentation

0bc1c11

MarekBodingerBA force-pushed the omit-extra-data branch from 6436257 to 0bc1c11 Compare March 29, 2024 11:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Omit extra data in schemaUtils #4139

Omit extra data in schemaUtils #4139

MarekBodingerBA commented Mar 22, 2024 •

edited

Loading

heath-freenome left a comment

heath-freenome Mar 22, 2024

heath-freenome Mar 22, 2024

heath-freenome commented Apr 1, 2024

MarekBodingerBA commented Apr 1, 2024

heath-freenome commented Apr 1, 2024

MarekBodingerBA commented Apr 2, 2024

heath-freenome commented Apr 5, 2024

heath-freenome commented May 10, 2024

heath-freenome commented Jul 1, 2024

MarekBodingerBA commented Jul 2, 2024

heath-freenome commented Jul 2, 2024 •

edited by nickgros

Loading

Omit extra data in schemaUtils #4139

Are you sure you want to change the base?

Omit extra data in schemaUtils #4139

Conversation

MarekBodingerBA commented Mar 22, 2024 • edited Loading

Reasons for making this change

Checklist

heath-freenome left a comment

Choose a reason for hiding this comment

heath-freenome Mar 22, 2024

Choose a reason for hiding this comment

heath-freenome Mar 22, 2024

Choose a reason for hiding this comment

heath-freenome commented Apr 1, 2024

MarekBodingerBA commented Apr 1, 2024

heath-freenome commented Apr 1, 2024

MarekBodingerBA commented Apr 2, 2024

heath-freenome commented Apr 5, 2024

heath-freenome commented May 10, 2024

heath-freenome commented Jul 1, 2024

MarekBodingerBA commented Jul 2, 2024

heath-freenome commented Jul 2, 2024 • edited by nickgros Loading

MarekBodingerBA commented Mar 22, 2024 •

edited

Loading

heath-freenome commented Jul 2, 2024 •

edited by nickgros

Loading