Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the arrays to be marked as "required" #420

Closed
wants to merge 2 commits into from

Conversation

crumblix
Copy link
Collaborator

@crumblix crumblix commented Nov 24, 2016

Reasons for making this change

New feature:

Enable the arrays to be marked as "required". Meaning that the user must select "at least one" option from the list.

This references the array part of ticket:
#411

Checklist

  • [x ] I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • [x ] I'm adding or updating code
    • I've added and/or updated tests
    • [x ] I've updated docs if needed
  • [x ] I'm adding a new feature
    • [x ] I've updated the playground with an example use of the feature

Test performed. I've set each of the items in the arrays section of the playground to required and get no errors or warnings ... other than the expected validation message due to an element being "required"

  "required": [
    "listOfStrings",
    "multipleChoicesList",
    "fixedItemsList",
    "nestedList",
    "unorderable",
    "unremovable",
    "noToolbar",
    "fixedNoToolbar"
  ],

@n1k0
Copy link
Collaborator

n1k0 commented Jan 17, 2017

It seems people are agreeing on this behavior and want to see it implemented in the lib, see ongoing dicussion in #402.

I'd like to make them happy and land this along #410, would you be willing to post your modifications as a single consistent PR so it's easier to review and discuss the implementation? Thanks!

@crumblix
Copy link
Collaborator Author

Sure thing! Happy to :)

I've got a busy day ahead but I'll try and get to it tonight if that's OK?

Just so as I've got what you want straight, I'll merge my changes for #410 into this PR?

@n1k0
Copy link
Collaborator

n1k0 commented Jan 17, 2017

I've got a busy day ahead but I'll try and get to it tonight if that's OK?

No rush, I'm going to bed (ahh the joys of timezones) ;)

Just so as I've got what you want straight, I'll merge my changes for #410 into this PR?

Works for me.

@crumblix
Copy link
Collaborator Author

This has now all been wrapped up in a new PR #442. This PR can be closed.

@n1k0 n1k0 closed this Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants