Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed .only on a core test and centralized esbuild #4243

Merged

Conversation

heath-freenome
Copy link
Member

@heath-freenome heath-freenome commented Jul 3, 2024

Reasons for making this change

One of the core tests was accidentally left as .only, undoing that as well as bumping most of the minor and patch package updates

  • Updated StringField.test.jsx to remove a .only
  • Centralized esbuild down to the main package.json
  • Updated the CHANGELOG.md accordingly

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome heath-freenome force-pushed the bump-packages-fix-core-ui-test branch 2 times, most recently from fa3aecb to 27a0c05 Compare July 4, 2024 02:36
One of the `core` tests was accidentally left as `.only`, undoing that as well as bumping most of the minor and patch package updates
- Updated `StringField.test.jsx` to remove a `.only`
- Centralized `esbuild` down to the main `package.json`
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome changed the title Removed .only on a core test and bump most minor and patch packages Removed .only on a core test and bump most minor and patch packages Jul 4, 2024
@heath-freenome heath-freenome force-pushed the bump-packages-fix-core-ui-test branch from 27a0c05 to 6cf7dd4 Compare July 4, 2024 02:51
@heath-freenome heath-freenome changed the title Removed .only on a core test and bump most minor and patch packages Removed .only on a core test and centralized esbuild Jul 4, 2024
@heath-freenome heath-freenome merged commit a2bd3eb into rjsf-team:main Jul 5, 2024
5 checks passed
@heath-freenome heath-freenome deleted the bump-packages-fix-core-ui-test branch July 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants