Bug: Issue with formData not updating when dependencies change #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested changes
Nov 22, 2024
nickgros
reviewed
Nov 22, 2024
|
@abdalla-rko Can you fix the tests? |
nickgros
reviewed
Dec 6, 2024
nickgros
reviewed
Dec 6, 2024
…e it thinks there isn't exactly one subschema that is valid.
4 tasks
CHANGELOG.md
Outdated
| @@ -16,6 +16,12 @@ should change the heading of the (upcoming) version to include a major version b | |||
|
|
|||
| --> | |||
|
|
|||
| # 5.24.0 | |||
There was a problem hiding this comment.
Should this be 5.23.3 since there isn't a new feature?
| } | ||
| return formData; | ||
| return overrideFormDataWithDefaults ? defaults : formData; |
There was a problem hiding this comment.
Is there a way to optimize this logic so that we have:
if (/*conditions for defaults*/) {
return defaults;
}
return formData;
Comment on lines
355
to
356
| * Ensure that the formData matches the given schema. If it's not matching in the case of a selectField, we change it to match the schema. | ||
| * @param validator - an implementation of the `ValidatorType` interface that will be used when necessary |
There was a problem hiding this comment.
Suggested change
| * Ensure that the formData matches the given schema. If it's not matching in the case of a selectField, we change it to match the schema. | |
| * @param validator - an implementation of the `ValidatorType` interface that will be used when necessary | |
| * Ensure that the formData matches the given schema. If it's not matching in the case of a selectField, we change it to match the schema. | |
| * | |
| * @param validator - an implementation of the `ValidatorType` interface that will be used when necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4325
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.