support dropdownParent option as a string #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny change to allow passing a string to the
dropdownParentoption, so it can be used even when the parent component is rendered isomorphically.We were unable to use this component initially because we needed the select2 dropdown to be appended to a particular element rather than the
<body>. Select2 does support adropdownParentoption, but unfortunately it requires an element instead of a string (although I feel like it should support a string selector). So perhaps we should be making this pull request to select2 instead, but updating the React component was the most immediate solution to our problem -- and the problem is in some sense specific to react, because the reason we can't pass in the element is because we don't always have access todocumentwhen we initiallyrender.