This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: common: mount also the host cgroup hierarchy #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this PR I managed to run rkt on Void Linux without needing to do anything else. For it to work I needed to create and join a subcgroup (see last commit). Isolators don't work, I'll look into it next week. |
iaguis
force-pushed
the
mount-host-cgroups
branch
from
2f51931
to
de42c55
Compare
|
Isolators work now too in Void Linux |
|
I tried this and it works as advertised. Thanks @iaguis! |
iaguis
force-pushed
the
mount-host-cgroups
branch
from
de42c55
to
b84c2c0
Compare
| // 1. Mount RW knobs we need to make the enabled isolators work | ||
| for _, c := range controllers { | ||
| cPath := filepath.Join(cgroupTmpfs, c) | ||
| // 1a. Check if we're running from a unit to know which subcgroup |
There was a problem hiding this comment.
The code below does not seem to check if you are running from a unit
We'll need it for mounting the host cgroups too.
iaguis
force-pushed
the
mount-host-cgroups
branch
5 times, most recently
from
9bacdfe
to
7c8a789
Compare
| var flags uintptr | ||
|
|
||
| // 1. Mount /sys read-only | ||
| // Mount /sys read-only |
To avoid problems on environments without a properly mounted cgroup hierarchy and/or without the systemd hierarchy we also mount the host cgroup hierarchy. Since we're in a different mount namespace the host is not affected.
systemd-nspawn doesn't allow the caller process to be in the root cgroup. If that is the case, we create and add ourselves to a new "rkt" subcgroup. Distributions like Void Linux put every process in the root cgroup by default so this allows rkt to work on them.
iaguis
force-pushed
the
mount-host-cgroups
branch
from
7c8a789
to
94b3fb5
Compare
|
LGTM if the tests pass. |
|
Thanks! |
iaguis
added a commit
that referenced
this pull request
Sep 24, 2015
stage1: common: mount also the host cgroup hierarchy
|
👍 |
|
Thanks for getting this done! I tried it and it works great. |
|
Yeah, thanks a lot @jaybuff! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid problems on environments without a properly mounted cgroup
hierarchy and/or without the systemd hierarchy we also deal with
mounting the host cgroup hierarchy.
Since we're in a different mount namespace the host is not affected.
Fixes #1320
Fixes #1076
Fixes #1042