This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Documentation: add prepare and run-prepared #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,32 @@ | |||
| # rkt prepare | |||
|
|
|||
| rkt can prepare images to run in a pod. This means it will fetch (if necessary) the images, extract them in its internal tree store, and allocate a pod UUID. | |||
There was a problem hiding this comment.
+"If overlay fs is not supported or is disabled, it will also copy the tree in the pod rootfs."
|
lgtm after the note about overlay fs. |
| @@ -0,0 +1,32 @@ | |||
| # rkt prepare | |||
There was a problem hiding this comment.
Could you add note explaining that the supported arguments should all be the same between prepare/run, and that e.g. rkt prepare + rkt run-prepared is semantically equivalent to rkt run?
|
One suggestion, lgtm after that. |
|
Updated. |
jonboulle
added a commit
that referenced
this pull request
Oct 2, 2015
Documentation: add prepare and run-prepared
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1348