This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: implement PodManifest.Mounts and --inject-volumes #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
force-pushed
the
mount-inject-volumes
branch
6 times, most recently
from
8010974
to
f1aaca5
Compare
|
|
||
| volName, err := types.SanitizeACName(p[1]) | ||
| if err != nil { | ||
| return fmt.Errorf("must be SOURCE_PATH:TARGET_PATH") |
There was a problem hiding this comment.
This error looks like a copypasta from above.
There was a problem hiding this comment.
It happens if the second part is empty (for example, /etc:) and I thought returning the same error msg would be fine. Any suggestions? I can create an error variable to avoid repetition.
iaguis
force-pushed
the
mount-inject-volumes
branch
2 times, most recently
from
bd45056
to
4c89e4c
Compare
iaguis
changed the title
iaguis
force-pushed
the
mount-inject-volumes
branch
from
4c89e4c
to
267ee6d
Compare
--mount flags preceding any apps apply globally to all apps, --mount flags succeeding any apps apply only to the nearest preceding app. also moves the volume list into rktApps.
Currently only checks for volume<->mount connectivity.
iaguis
force-pushed
the
mount-inject-volumes
branch
2 times, most recently
from
360109d
to
19a08a5
Compare
This flag allows injecting volumes into apps using source and target
paths.
Example:
rkt run app.aci --inject-volume /data:/var/lib/data
iaguis
force-pushed
the
mount-inject-volumes
branch
from
19a08a5
to
d04c8b2
Compare
| Group: "0", | ||
| MountPoints: []types.MountPoint{ | ||
| { | ||
| Name: "foo-mount", |
iaguis
force-pushed
the
mount-inject-volumes
branch
from
edab3e1
to
ace29cb
Compare
|
Updated. |
|
LFAD. |
iaguis
added a commit
that referenced
this pull request
Oct 21, 2015
stage1: implement PodManifest.Mounts and --inject-volumes
jonboulle
added a commit
to jonboulle/rkt
that referenced
this pull request
Oct 23, 2015
The syntax of `--inject-volume` has been somewhat contentious [1][1] and it seems pretty clear we do not want the flag to remain as-is. Furthermore, there's actually no immediate need for it since the same functionality can be achieved through a combination of the `--volume` and `--mount` flags (which landed in the same PR as `--inject-volume`). Hence, remove it for now, guide people towards the alternative, and we can put further thought into re-adding something similar in future (which would essentially just be a convenience). [1]: rkt#1656 [2]: rkt#1582
jonboulle
added a commit
to jonboulle/rkt
that referenced
this pull request
Oct 23, 2015
The syntax of `--inject-volume` has been somewhat contentious [1][1] and it seems pretty clear we do not want the flag to remain as-is. Furthermore, there's actually no immediate need for it since the same functionality can be achieved through a combination of the `--volume` and `--mount` flags (which landed in the same PR as `--inject-volume`). Hence, remove it for now, guide people towards the alternative, and we can put further thought into re-adding something similar in future (which would essentially just be a convenience). [1]: rkt#1656 [2]: rkt#1582
jonboulle
added a commit
to jonboulle/rkt
that referenced
this pull request
Oct 23, 2015
The syntax of `--inject-volume` has been somewhat [contentious][1] and it seems pretty clear we do not want the flag to remain as-is. Furthermore, there's actually no immediate need for it since the same functionality can be achieved through a combination of the `--volume` and `--mount` flags (which landed in the [same PR][2] as `--inject-volume`). Hence, remove it for now, guide people towards the alternative, and we can put further thought into re-adding something similar in future (which would essentially just be a convenience). [1]: rkt#1656 [2]: rkt#1582
jonboulle
added a commit
to jonboulle/rkt
that referenced
this pull request
Oct 23, 2015
The syntax of `--inject-volume` has been somewhat [contentious][1] and it seems pretty clear we do not want the flag to remain as-is. Furthermore, there's actually no immediate need for it since the same functionality can be achieved through a combination of the `--volume` and `--mount` flags (which landed in the [same PR][2] as `--inject-volume`). Hence, remove it for now, guide people towards the alternative, and we can put further thought into re-adding something similar in future (which would essentially just be a convenience). [1]: rkt#1656 [2]: rkt#1582
jonboulle
added a commit
to jonboulle/rkt
that referenced
this pull request
Oct 23, 2015
The syntax of `--inject-volume` has been somewhat [contentious][1] and it seems pretty clear we do not want the flag to remain as-is. Furthermore, there's actually no immediate need for it since the same functionality can be achieved through a combination of the `--volume` and `--mount` flags (which landed in the [same PR][2] as `--inject-volume`). Hence, remove it for now, guide people towards the alternative, and we can put further thought into re-adding something similar in future (which would essentially just be a convenience). [1]: rkt#1656 [2]: rkt#1582
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 27, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 27, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 27, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 27, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 27, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 28, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
iaguis
added a commit
to iaguis/rkt
that referenced
this pull request
Oct 28, 2015
In rkt#1582 we added support for PodManifest.Mounts but we didn't consider the kvm flavor. This commit adds support for the kvm flavor and refactors the code a bit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #770
Implement positional --mount
--mount flags preceding any apps apply globally to all apps,
--mount flags succeeding any apps apply only to the nearest preceding app.
Add --inject-volume flag
This flag allows injecting volumes into apps using source and target
paths.
Example:
Fixes #1467
Fixes #761