This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Godeps: resync with appc/spec v0.7.3 #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
force-pushed
the
alban/appc-spec-0.7.2
branch
3 times, most recently
from
d9e16dc to
340f128
Compare
|
The test I filed appc/spec#542 for this. |
alban
force-pushed
the
alban/appc-spec-0.7.2
branch
from
340f128 to
a32e676
Compare
alban
changed the title
|
I added a second commit in this PR to fix appc/spec#542 (appc/spec#543) and to see if the tests pass in Semaphore. And it passes: https://semaphoreci.com/coreos/rkt/branches/pull-request-1800/builds/5 @jonboulle should we do another release of appc/spec to fix that? |
The new appc/spec also needs this dependency: - github.com/camlistore/camlistore/pkg/errorutil The rkt code has been changed to use the new prototype of discovery.DiscoverEndpoints. It will need further changes to use the per-host credentials: see rkt#1516 The test TestPodManifest has been updated to compile, following the changes in struct types.Volume. I just added "nil, nil, nil" for the new fields. Permissions for empty volumes are not tested. Further changes will be needed for rkt#1523 Fixes rkt#1792
alban
force-pushed
the
alban/appc-spec-0.7.2
branch
from
a32e676 to
1ee3256
Compare
alban
changed the title
|
Updated to use appc/spec v0.7.3. |
|
Huh why did all these vendored license files only just get picked up.. Other than that oddity looks OK to me |
|
We use one small piece of |
|
Green! |
alban
added a commit
that referenced
this pull request
Nov 26, 2015
Godeps: resync with appc/spec v0.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new appc/spec also needs this dependency:
The rkt code has been changed to use the new prototype of
discovery.DiscoverEndpoints. It will need further changes to use the
per-host credentials: see #1516
The test TestPodManifest has been updated to compile, following the
changes in struct types.Volume. I just added "nil, nil, nil" for the new
fields. Permissions for empty volumes are not tested. Further changes
will be needed for #1523
Fixes #1792