Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

Documentation/trying-out-rkt: Update for clarity and style #2825

Merged
merged 1 commit into from
Jun 29, 2016

Conversation

joshix
Copy link
Contributor

@joshix joshix commented Jun 22, 2016

Addressing #2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.


## Using rkt on Linux

rkt consists of a single CLI tool and can run on different platforms. The primary target platform currently is amd64 Linux. A modern kernel is required but there should be no other system dependencies.
rkt consists of a single command line program compiled for Linux on the amd64 architecture. A modern Linux kernel is required, but there are no other system prerequisites.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going in the exact opposite direction of #2808 (comment) Or is that on purpose and I'm lacking some further context here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm similarly confused

Copy link
Contributor Author

@joshix joshix Jun 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on purpose -- We do not at this release (1.9) or time deliver any arch but amd64.

When #2758 merges and there is support, that's when I think this doc gets an update. Until then it just tells the unalloyed fact, because we're specifically documenting the binary rkt here, not instructing on how you might compile for archs that will later be supported.

Consider what we might say instead: "rkt is compiled as an amd64 binary, but could be compiled on other architectures"? -- which ones, how, and does the result work?

Which brings me to my question about this, that maybe changes my opinion on how we write this sentence: What does debian's rkt 1.5 package actually do on a 64 bit ppc? Does it work?

@lucab lucab self-assigned this Jun 23, 2016
@tmrts tmrts removed their assignment Jun 23, 2016
@lucab lucab modified the milestones: v1.10.0, v1.9.0 Jun 23, 2016
@lucab
Copy link
Member

lucab commented Jun 24, 2016

@philips @jonboulle I had a quick chat with @joshix and the new wording should clarify the split between writing arch-agnostic code and distributing pre-compiled binaries. If it sounds ok for you, we can just squash this here.

@jonboulle
Copy link
Contributor

@squeed Review on this would be appreciated since you're new to this

To download the rkt binary, simply grab the latest release directly from GitHub:
### Running the latest rkt binary

To start running the latest version of rkt on amd64, grab the release directly from the rkt GitHub project:

```
wget https://github.com/coreos/rkt/releases/download/v1.8.0/rkt-v1.8.0.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now we're at v1.9.1 :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible bug from the scripts/bump-version.sh script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind it's not rebased

@squeed
Copy link
Contributor

squeed commented Jun 28, 2016

I gave this a quick review, as I'm currently in the process of bringing myself on-board. Ultimately, it probably would have been more helpful if there was a stronger step-by-step feel with better indication as to what is "deeper". However, I'm not sure it's that important or worth additional time.

@joshix
Copy link
Contributor Author

joshix commented Jun 28, 2016

(rebased)


## Using rkt on Linux

rkt consists of a single CLI tool and can run on different platforms. The primary target platform currently is amd64 Linux. A modern kernel is required but there should be no other system dependencies.
rkt is written in Go and can be compiled for several CPU architectures. The rkt project distributes binaries for amd64. These rkt binaries will run on any modern Linux amd64 kernel.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2758 (arm64 support) is merged, so it needs an update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not until we sort out if/how we pre-compile and distribute arm64 binaries.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah true. I was too hasty.

@lucab
Copy link
Member

lucab commented Jun 29, 2016

@joshix can you please squash them into a single commit? LGTM otherwise.

Addressing rkt#2808 (diff)

Update to clarify the 3 use cases (actually 4, since we describe Vagrant
on linux as well).
Update for styleguide stuff - ref links, sentence case, fmt.
Update etcd ACI version and hashes to v2.3.7.
@joshix
Copy link
Contributor Author

joshix commented Jun 29, 2016

@lucab squished

@lucab lucab merged commit 1369b6f into rkt:master Jun 29, 2016
@joshix joshix deleted the tryoutrw branch July 5, 2016 21:40
@lucab lucab unassigned squeed Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants