This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
functional tests: really skip failed remote fetches #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
force-pushed
the
iaguis/really-skip-failed-remote-fetches
branch
from
a1448e7
to
b2068af
Compare
Another stab at skipping remote fetches that fail. Previously we were failing before we could check the exit status when we expected a regexp, so we missed the chance to skip the test. Fix that and refactor the code to a checkExitStatus() function so we don't repeat ourselves.
iaguis
force-pushed
the
iaguis/really-skip-failed-remote-fetches
branch
from
b2068af
to
4557b84
Compare
|
LGTM |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another stab at skipping remote fetches that fail.
Previously we were failing before we could check the exit status when we
expected a regexp, so we missed the chance to skip the test.
Fix that and refactor the code to a checkExitStatus() function so we
don't repeat ourselves.