This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
functional tests: skip TestSocketProxyd #3049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this racy also on kvm flavor? kvm flavor is not using nspawn. |
| @@ -34,6 +34,10 @@ import ( | |||
| ) | |||
|
|
|||
| func TestSocketProxyd(t *testing.T) { | |||
| // Skip the test for now. See https://github.com/coreos/rkt/issues/1464 for | |||
| // details. | |||
There was a problem hiding this comment.
Shouldn't you link to this too?
#2432 (comment)
|
@krnowak Not sure, as due to nested-virtualization requirement kvm tests are only running on semaphore at the moment. |
This test is currently racy. The socket-activated proxyd service depends on a rkt service being ready. However, the application that runs inside rkt doesn't have a way to signal when it's ready because of rkt#1464. Instead, systemd assumes it's ready when the container starts, which is wrong, because the application inside might not be listening on the port yet. This makes the test fail. It fails a lot particularly in Fedora Rawhide with the flavor host: https://jenkins-rkt-public.prod.coreos.systems/job/rkt-master-periodic/os_type=fedora-rawhide,stage1_flavor=host/ We can re-enable it when we fix rkt#1464.
iaguis
force-pushed
the
iaguis/skip-socket-proxyd-test
branch
from
0eb6fd9
to
01e85a5
Compare
|
@krnowak it is racy on kvm too because the kvm flavor does not support sdnotify and @alepuccetti's PR #2826 only implements the sdnotify mechanism in the nspawn flavor. It is annoying because the test and documentation about systemd-socket-proxyd was added only for the benefit of the kvm flavor: on the nspawn flavor, users can just use normal socket activation, so they don't need systemd-socket-proxyd. |
|
#2943 strikes again. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently racy. The socket-activated proxyd service depends
on a rkt service being ready. However, the application that runs inside
rkt doesn't have a way to signal when it's ready because of
#1464. Instead, systemd assumes it's
ready when the container starts, which is wrong, because the application
inside might not be listening on the port yet. This makes the test fail.
It fails a lot particularly in Fedora Rawhide with the flavor host:
https://jenkins-rkt-public.prod.coreos.systems/job/rkt-master-periodic/os_type=fedora-rawhide,stage1_flavor=host/
We can re-enable it when we fix #1464.
cc @woodbor