This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
Docs: some review on stage1-implementors-guide.md #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch : - Remove duplicate words - Keep the format of "Entrypoints(run,enter,gc,stop)" consistent - Fix typo Signed-off-by: Hu Keping <hukeping@huawei.com>
|
Can one of the admins verify this patch? |
|
Actually this change should be in the previous PR #3096 as well, but due to @jonboulle 's rapid reviewing and merging, I was still reading this document when he merged it. lol |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch :
Signed-off-by: Hu Keping hukeping@huawei.com