-
Notifications
You must be signed in to change notification settings - Fork 883
cri: initial implementation of stage1 changes #3218
Conversation
For a reference here is the stat-diff towards the cri branch:
|
I set the |
CI looks green enough for |
[Unit] | ||
Description=Halt | ||
DefaultDependencies=no | ||
AllowIsolate=yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unit is still referenced in many places, but it is removed here. How does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generated programmatically in https://github.com/coreos/rkt/pull/3218/files#diff-99ef63dd92c607458ff979e0c391eb56R68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add a little bit more context: the halt.target
has a Requires/After
dependency on shutdown.service
in the case of mutable pods. This prevents mutable pods to shut down prematurely if there are no applications started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR pulls the stage1-based changes from the CRI branch back into
master, leaving out the changes in stage0 (new app subcommands).
Being in the beginning of the next release cycle this gives us the
opportunity to merge the first CRI efforts.
/cc @yifan-gu @lucab @squeed @alban
Relates to #2992