Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

api-service: stop erroring when a pod is running #3525

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jan 10, 2017

Fixes #3504

This silences this silly error message. This logic isn't exactly correct, but I've filed another issue to fix that.

@jonboulle
Copy link
Contributor

I don't understand, this is going to assign a 0 exit value isn't it?

@squeed
Copy link
Contributor Author

squeed commented Jan 10, 2017

It already does. The error message just pollutes stderr - it doesn't change the behavior.

@jonboulle
Copy link
Contributor

jonboulle commented Jan 10, 2017 via email

Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the caveat that the whole surrounding logic needs to be revamped as per #3524.

@squeed
Copy link
Contributor Author

squeed commented Jan 11, 2017

The only failure is our good friend, TestAppUserSandbox. This is "green".

@squeed squeed merged commit 03cfc3d into rkt:master Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api-service complains about missing status file of app that is still running (never exited)
3 participants