Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage0/run: relax '--hosts-entry' parser #3833

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Conversation

lucab
Copy link
Member

@lucab lucab commented Oct 23, 2017

This tweaks the '--hosts-entry' CLI flag parser to accept multiple
time the special value "host" when there are no other conflicting
settings.

This tweaks the '--hosts-entry' CLI flag parser to accept multiple
time the special value "host" when there are no other conflicting
settings.
@lucab
Copy link
Member Author

lucab commented Oct 23, 2017

/cc @squeed

@lucab
Copy link
Member Author

lucab commented Oct 23, 2017

@euank I think CL may need this to go together with the kubelet-wrapper change, would you mind a review? See poseidon/matchbox#662 for context.

/cc @dghubble

@dghubble
Copy link
Contributor

dghubble commented Oct 23, 2017

This would be a welcome addition to avoid breaking any users who already set the flag directly. 👍

rel: coreos/coreos-overlay#2839, kubernetes-retired/bootkube#740

@euank
Copy link
Member

euank commented Oct 23, 2017

I guess now if someone noticed this before and fixed it with the alternate --host-entry "127.0.0.1=localhost" it will fail and there's no particularly good way for the user to override this without forking the whole script.

I think this is probably the best approach we have still in the face of reality.

@lucab
Copy link
Member Author

lucab commented Oct 24, 2017

@euank right, this can't help resolving ambiguous inputs. It just relaxes the multiple-special-values case.

@lucab lucab merged commit 6428df7 into rkt:master Oct 24, 2017
@iaguis iaguis added this to the 1.30.0 milestone Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants