Fix comic upc field name #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuykendall
approved these changes
Aug 25, 2021
|
@bpepple I tried to release this and the previous commit, but Travis isn't running my builds for some reason. I reached out to support. If they don't get back to me, I'm glad we have a Github Actions switch prepared! |
|
@rkuykendall I've been bitten by the pypi github action not triggering when tagging a release a few times, and I've slowly been migrating some of my projects to use poetry to make publishing easier and not at the mercy of gh actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the upc code was originally added as 'up' in the ComicSchema. This pull is a minor change to correct that.