Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to latest version to make it compatible with latest Django release #7

Merged
merged 1 commit into from
May 13, 2020

Conversation

Naouak
Copy link
Contributor

@Naouak Naouak commented May 13, 2020

There is some breaking changes from Marshmallow 3+ that would made the library unusable on a django 3.0 project.

@codecov-io
Copy link

Codecov Report

Merging #7 into master will decrease coverage by 12.81%.
The diff coverage is 97.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #7       +/-   ##
===========================================
- Coverage   99.11%   86.29%   -12.82%     
===========================================
  Files          10       10               
  Lines         226      270       +44     
===========================================
+ Hits          224      233        +9     
- Misses          2       37       +35     
Impacted Files Coverage Δ
marvelous/session.py 58.82% <85.71%> (-39.40%) ⬇️
marvelous/comic.py 93.18% <100.00%> (-6.82%) ⬇️
marvelous/comics_list.py 95.83% <100.00%> (-4.17%) ⬇️
marvelous/dates.py 100.00% <100.00%> (ø)
marvelous/events.py 100.00% <100.00%> (ø)
marvelous/series.py 94.28% <100.00%> (-2.15%) ⬇️
marvelous/urls.py 95.83% <100.00%> (-4.17%) ⬇️
marvelous/sqlite_cache.py 88.23% <0.00%> (-11.77%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07f999...33c9cf9. Read the comment docs.

@rkuykendall
Copy link
Owner

Beautiful work, thank you! I will work to have this published today.

@rkuykendall rkuykendall merged commit e30fbbf into rkuykendall:master May 13, 2020
@rkuykendall
Copy link
Owner

Released in v1.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants