Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session.series_list to list series #9

Merged
merged 1 commit into from
May 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,13 @@ m.series(series_id)
Calls the `/v1/public/series/{seriesId}` endpoint with the first
argument and returns a `Series` object.

m.series_list(params=None)
.....................

Calls the `/v1/public/series` endpoint with any params passed in and
returns a `SeriesList` object. For documentation on `SeriesList`, see below. For
documentation on all the params argument, see the
`Marvel API documentation <https://developer.marvel.com/docs#!/public/getSeriesCollection_get_25>`_


Objects
Expand Down Expand Up @@ -190,6 +197,12 @@ Series
- ``comics`` - Method, Returns ``ComicsList`` object for `/v1/public/series/{seriesId}/comics`


SeriesList
..........

- ``series`` - List, ``Series`` objects
- ``response`` - Dictionary, raw response body


Exceptions
----------
Expand Down
33 changes: 33 additions & 0 deletions marvelous/series_list.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import itertools

from marshmallow import ValidationError

from . import exceptions, series


class SeriesList():
def __init__(self, response):
self.series = []
self.response = response

schema = series.SeriesSchema()
for series_dict in response['data']['results']:
try:
result = schema.load(series_dict)
except ValidationError as error:
raise exceptions.ApiError(error)

self.series.append(result)

def __iter__(self):
return iter(self.series)

def __len__(self):
return len(self.series)

def __getitem__(self, index):
try:
return next(itertools.islice(self.series, index, index + 1))
except TypeError:
return list(itertools.islice(
self.series, index.start, index.stop, index.step))
9 changes: 8 additions & 1 deletion marvelous/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from marshmallow import ValidationError

from . import exceptions, comics_list, series
from . import exceptions, comics_list, series, series_list


class Session():
Expand Down Expand Up @@ -86,3 +86,10 @@ def series(self, _id):

result.session = self
return result

def series_list(self, params=None):
if params is None:
params = {}

return series_list.SeriesList(
self.call(['series'], params=params))
7 changes: 7 additions & 0 deletions tests/series_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,12 @@ def test_bad_response_data(self):
with self.assertRaises(marvelous.exceptions.ApiError):
ComicsList({'data': {'results': [{'modified': 'potato'}]}})

def test_pulls_verbose(self):
series = self.m.series_list({
'orderBy': 'modified',
})

self.assertGreater(len(series.series), 0)

if __name__ == '__main__':
unittest.main()
Binary file modified tests/testing_mock.sqlite
Binary file not shown.