Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit-hooks #56

Merged
merged 17 commits into from
Aug 21, 2023
Merged

Add pre-commit-hooks #56

merged 17 commits into from
Aug 21, 2023

Conversation

jh-RLI
Copy link
Contributor

@jh-RLI jh-RLI commented Aug 17, 2023 •
edited by Ludee
Loading

Summary of the discussion

Add the pre-commit configuration. Explain usage and add all changes and fixes applied by the hooks to improve the current code quality.

Type of change (CHANGELOG.md)

Added

  • Add and run pre-commit and setup pre-commit-hooks (#56)

Workflow checklist

Automation

Closes #30

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@jh-RLI jh-RLI self-assigned this Aug 17, 2023
@jh-RLI jh-RLI changed the base branch from production to develop August 17, 2023 11:20
@jh-RLI jh-RLI marked this pull request as ready for review August 17, 2023 11:51
@jh-RLI jh-RLI requested a review from Ludee August 17, 2023 11:51
Ludee
Ludee approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start and documentation for the installation and setup! Thanks

@Ludee Ludee added part: docu 📖 Concerns the documentation part: backend 🧱 Concerns backend components type: feature 🛠️ Implementation of a new feature status: completed ✔️ Has been completed priority: high ⚡ High priority labels Aug 21, 2023
@Ludee Ludee merged commit 85c46e9 into develop Aug 21, 2023
@Ludee Ludee deleted the feature-30/add-pre-commit-hook branch August 21, 2023 08:38
@Ludee Ludee mentioned this pull request Dec 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ludee Ludee Ludee approved these changes

Assignees

@jh-RLI jh-RLI

Labels
part: backend 🧱 Concerns backend components part: docu 📖 Concerns the documentation priority: high ⚡ High priority status: completed ✔️ Has been completed type: feature 🛠️ Implementation of a new feature
Projects
None yet
Milestone
Complete and document field: GIT
Development

Successfully merging this pull request may close these issues.

Pre-commit and Pre-commit hooks are missing
2 participants
@jh-RLI @Ludee