Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word list should be internal data? #2

Closed
hadley opened this issue Jul 30, 2015 · 3 comments
Closed

Word list should be internal data? #2

hadley opened this issue Jul 30, 2015 · 3 comments

Comments

@hadley
Copy link

hadley commented Jul 30, 2015

i.e. in R/sysdata.rda since it's to be used by the package, not by users of the pacakge

@gaborcsardi
Copy link
Collaborator

I would keep it in a "text" file, actually, because then people can see it on GitHub, and also easily submit pull requests.

I know I could still build a sysdata.rda, but that also complicates pull requests.

I don't see this package having a lot of words, at most a couple of thousands, so I think for now the text files are fine.

@hadley
Copy link
Author

hadley commented Jul 30, 2015

Ok, but be prepared for awkwardness when trying to access that data within R/

@hadley hadley closed this as completed Jul 30, 2015
@gaborcsardi
Copy link
Collaborator

Maybe I'll just put it in R/ then, as regular R objects. No trouble then I think.

gaborcsardi added a commit that referenced this issue Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants