fix(invoke-usage): allow multiple services to be invoked

rlaffers · Jul 28, 2021 · 25c252d · 25c252d
1 parent 6f7da29
commit 25c252d
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 25 deletions.
diff --git a/lib/rules/invoke-usage.js b/lib/rules/invoke-usage.js
@@ -32,33 +32,41 @@ module.exports = {
     return {
       'CallExpression[callee.name=/^createMachine$|^Machine$/] Property[key.name="invoke"]':
         function (node) {
-          if (node.value.type !== 'ObjectExpression') {
-            context.report({
-              node,
-              messageId: 'invokeIsNotObject',
-            })
-            return
-          }
-          if (!hasProperty('src', node.value)) {
-            context.report({
-              node,
-              messageId: 'invokeObjectLacksSrc',
-            })
-            return
-          }
-          const src = node.value.properties.find(propertyHasName('src'))
-          if (
-            !isStringLiteralOrIdentifier(src.value) &&
-            !isFunctionExpression(src.value) &&
-            src.value.type !== 'ObjectExpression' &&
-            !isCreateMachineCall(src.value)
-          ) {
-            context.report({
-              node: src,
-              messageId: 'srcPropertyIsInvalid',
-            })
+          if (node.value.type === 'ArrayExpression') {
+            node.value.elements.forEach((node) => testInvokeDefinition(node))
+          } else {
+            testInvokeDefinition(node.value)
           }
         },
     }
+
+    function testInvokeDefinition(node) {
+      if (node.type !== 'ObjectExpression') {
+        context.report({
+          node,
+          messageId: 'invokeIsNotObject',
+        })
+        return
+      }
+      if (!hasProperty('src', node)) {
+        context.report({
+          node,
+          messageId: 'invokeObjectLacksSrc',
+        })
+        return
+      }
+      const src = node.properties.find(propertyHasName('src'))
+      if (
+        !isStringLiteralOrIdentifier(src.value) &&
+        !isFunctionExpression(src.value) &&
+        src.value.type !== 'ObjectExpression' &&
+        !isCreateMachineCall(src.value)
+      ) {
+        context.report({
+          node: src,
+          messageId: 'srcPropertyIsInvalid',
+        })
+      }
+    }
   },
 }
diff --git a/tests/lib/rules/invoke-usage.js b/tests/lib/rules/invoke-usage.js
@@ -39,6 +39,26 @@ const tests = {
         },
       })
     `,
+    `
+      createMachine({
+        initial: 'active',
+        states: {
+          active: {
+            invoke: [
+              {
+                src: () => [],
+              },
+              {
+                src: 'someService',
+              },
+              {
+                src: someService,
+              },
+            ],
+          },
+        },
+      })
+    `,
   ],
   invalid: [
     {
@@ -72,6 +92,33 @@ const tests = {
         { messageId: 'srcPropertyIsInvalid' },
       ],
     },
+    {
+      code: `
+        createMachine({
+          initial: 'active',
+          states: {
+            active: {
+              invoke: [
+                () => {},
+                'someService',
+                {
+                  onDone: 'stopped',
+                },
+                {
+                  src: true,
+                }
+              ]
+            },
+          },
+        })
+      `,
+      errors: [
+        { messageId: 'invokeIsNotObject' },
+        { messageId: 'invokeIsNotObject' },
+        { messageId: 'invokeObjectLacksSrc' },
+        { messageId: 'srcPropertyIsInvalid' },
+      ],
+    },
   ],
 }