fix(no-inline-implementation): detect inline implementations inside c…

…hoose action creator
rlaffers · May 12, 2021 · 8f8b9d3 · 8f8b9d3
1 parent 2891ee1
commit 8f8b9d3
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/lib/rules/no-inline-implementation.js b/lib/rules/no-inline-implementation.js
@@ -60,6 +60,12 @@ const propertyOfOnDoneOnErrorTransitionInArray =
 const activitiesProperty =
   'CallExpression[callee.name=/^createMachine$|^Machine$/] Property[key.name="activities"]'
 
+const propertyOfChoosableActionObject =
+  'CallExpression[callee.name=/^createMachine$|^Machine$/] CallExpression[callee.name="choose"] > ArrayExpression > ObjectExpression > Property'
+
+const propertyOfChoosableActionObjectAlt =
+  'CallExpression[callee.name=/^createMachine$|^Machine$/] CallExpression[callee.type="MemberExpression"][callee.object.name="actions"][callee.property.name="choose"] > ArrayExpression > ObjectExpression > Property'
+
 const defaultOptions = {
   allowKnownActionCreators: false,
 }
@@ -161,6 +167,8 @@ module.exports = {
       [propertyOfAltEventTransitionInArray]: checkTransitionProperty,
       [propertyOfOnDoneOnErrorTransition]: checkTransitionProperty,
       [propertyOfOnDoneOnErrorTransitionInArray]: checkTransitionProperty,
+      [propertyOfChoosableActionObject]: checkTransitionProperty,
+      [propertyOfChoosableActionObjectAlt]: checkTransitionProperty,
 
       [activitiesProperty]: function (node) {
         if (