fix(invoke-usage): allow function calls as valid invoke.src values

fix #7
rlaffers · Aug 16, 2021 · ac27f4b · ac27f4b
1 parent b01ca68
commit ac27f4b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/rules/invoke-usage.js b/lib/rules/invoke-usage.js
@@ -7,6 +7,7 @@ const {
   isStringLiteralOrIdentifier,
   isFunctionExpression,
   isCreateMachineCall,
+  isCallExpression,
 } = require('../utils/predicates')
 
 module.exports = {
@@ -24,7 +25,7 @@ module.exports = {
         'The value of the "invoke" property must be an object with a "src" property.',
       invokeObjectLacksSrc: 'The "invoke" object must have a "src" property.',
       srcPropertyIsInvalid:
-        'The value of the "src" property in the "invoke" object must be a machine, function, string or an object.',
+        'The value of the "src" property in the "invoke" object must be a machine, function, string, object, or a function call.',
     },
   },
 
@@ -59,6 +60,7 @@ module.exports = {
       if (
         !isStringLiteralOrIdentifier(src.value) &&
         !isFunctionExpression(src.value) &&
+        !isCallExpression(src.value) &&
         src.value.type !== 'ObjectExpression' &&
         !isCreateMachineCall(src.value)
       ) {

diff --git a/tests/lib/rules/invoke-usage.js b/tests/lib/rules/invoke-usage.js
@@ -39,6 +39,18 @@ const tests = {
         },
       })
     `,
+    `
+      createMachine({
+        initial: 'active',
+        states: {
+          active: {
+            invoke: {
+              src: someMachineCreator(),
+            },
+          },
+        },
+      })
+    `,
     `
       createMachine({
         initial: 'active',