Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve sass-loader to avoid phantom dependencies #25

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

ChrisCindy
Copy link
Contributor

No description provided.

@odeadglaz
Copy link

odeadglaz commented Nov 9, 2022

Any plans of getting this merged? I also encountered a case where this solution makes more sense.

also, if you look at how docusaurus defined their webpack loaders, it's quite the same.

@rlamana
Copy link
Owner

rlamana commented Dec 11, 2022

@odeadglaz @ChrisCindy What is the case where this solution makes sense? I'm good with the change but I'd like more context on why it is needed? The PR description lacks an explanation. Thank you!

@luhc228
Copy link

luhc228 commented Feb 22, 2023

@odeadglaz @ChrisCindy What is the case where this solution makes sense? I'm good with the change but I'd like more context on why it is needed? The PR description lacks an explanation. Thank you!

The @docusaurus/core and the docusaurus-plugin-sass packages are not on the same level in the node_modules.

@odeadglaz
Copy link

Thats correct, in the case of mono repo, the deps might not be present in the same level.

@luhc228
Copy link

luhc228 commented Feb 24, 2023

So will this PR be merged?

@rlamana
Copy link
Owner

rlamana commented Feb 24, 2023

Looks good to me then 👍

@rlamana rlamana merged commit 7ce5293 into rlamana:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants