Maximized window behavior #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlamana
approved these changes
Jun 19, 2018
| this.signals.emit('maximize', this, this._restoreMaximized); | ||
| } | ||
| else { | ||
| this.el.removeClass('maximized'); |
There was a problem hiding this comment.
This is good, but I realized there are cases where the classes of the element do not reflect the state of the window. For example, if you maximize it and then minimize, this code is not executed and the class maximized will not be removed.
We need to completely change the way classes and state is synced (an issue not trivial to solve with this "vanilla js" library).
The bug was already there so I don't think it is a blocker for this PR. Thanks for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix OS-specific issue on Windows where
\nwould be replaced with\r\nin Handlebars templates. See problem here. Solution was to usegulp-frepon thetemplatestask.Add class
.maximizedto a window when maximized. Address Add class.maximizedto a window when maximized #60.Disable movement of maximized windows. Address Maximized windows should not be movable #65.