Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize from edges #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andreybutenko
Copy link
Contributor

This PR addresses #69, enabling windows to be resized from any edge or corner.

I'm new to contributing to open-source, so please let me know if you have any feedback -- I'd be happy to implement changes.

Some details:

  • Add Window class variable _mouseEdgePosition that provides information on what edges the mouse cursor is hovering over.
  • Add Window class getters for mouseOnWindowEdge, resizingHorizontally, and resizingVertically.
  • Add Window class method startResize(e).
  • Add CSS classes to window which changes cursors according to what direction the window can be resized towards.
  • Sensitivity of what's considered an "edge" can be adjusted.

@rlamana
Copy link
Owner

rlamana commented Aug 14, 2018

@andreybutenko Please resolve the conflicts.

These problems with the dist files should be solved once the branch v0.3.0 is merged. This is a branch where I have been working on a migration to webpack and upgraded a little this old code.

@danimesq
Copy link

@rlamana, is this PR still valid merging by solving the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants