Multiple close/open support #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlamana
requested changes
Aug 14, 2018
| @@ -1088,7 +1088,7 @@ define('ventus/core/view', ['$'], function ($) { | |||
| }); | |||
| }, | |||
| onAnimationEnd: function (callback, scope) { | |||
| this.one(animationEventNames, function () { | |||
| this.on(animationEventNames, function () { | |||
There was a problem hiding this comment.
This will lead to memory leaks since the event listener is never unregistered.
There was a problem hiding this comment.
Hi, thanks for reviewing, I just made an update.
|
I understand the issue here, but I'm not sure if this is the right solution. Generally, this only happens when programmatically you close and then open a window, which occurs so fast that the animationEnd event handler of the open operation is executed before the window is even closed. I don't clearly see the use case however, I would approach this by either:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The following:
during the same JavaScript frame breaks the behavior and the window can be lost forever.
This PR prevents such issue.
Let me know what do you think