Merge IP constructors into base class #21
Conversation
|
Rather than go through a rebase - it was simpler to copy paste the code over into a new branch. |
|
@rlanvin - What are your thoughts on the PRs? |
src/IP.php
Outdated
| /** | ||
| * @param int $ip | ||
| */ | ||
| private function fromInt($ip) |
There was a problem hiding this comment.
For the from* methods, it would be nice to have type hinting. As discussed in #8 it makes sense to only support PHP >= 7.
I also think these from* should be static and return $ip.
There was a problem hiding this comment.
When you say "should return $ip", do you mean return the \GMP instance or an instance of PhpIP\IP?
There was a problem hiding this comment.
I mean the GMP instance, so in the constructor it would look like "$this->ip = self::fromInt($ip)".
|
@samuelwilliams My apologies. I got carried away by other projects and completely forgot about the open PRs here. Thanks for reminding me. |
|
Do you want this PR to change the minimum PHP requirements in |
|
@samuelwilliams No please make a separate independent PR for this. And it should not have any dependencies or include any other commits from another other currently open PRs. |
No description provided.