Add proper typing for EuiSubNav's renderItem #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
thompsongl
approved these changes
Feb 5, 2020
| interface GuaranteedRenderItemProps { | ||
| href: string | undefined; | ||
| onClick: ItemProps['onClick'] | undefined; | ||
| className: string; |
There was a problem hiding this comment.
Suggested change
| className: string; | |
| className?: string; |
There was a problem hiding this comment.
className always exists when renderItem is called (it is built up as buttonClasses in the method)
|
Thanks @thompsongl, updated! |
|
Nice! Can I merge? |
|
@rlesniak go for it! After that I'll do another review pass at elastic#2818 and think it will be ready to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full type definitions for
renderRenderprop. Will now error if using a prop that isn't defined, and also validates the types of those props.Using
EuiSideNavItemdirectly is a bit awkward and requires explicitly typing the argument valuesBut
EuiSideNavpicks up the definitions, and this is what downstream consumers use