wip #1
rlespinasseAnnotations
16 warnings
|
`to_string` applied to a type that implements `Display` in `println!` args:
src/wints/ops/wints_search.rs#L85
warning: `to_string` applied to a type that implements `Display` in `println!` args
--> src/wints/ops/wints_search.rs:85:69
|
85 | Err(why) => println!("can't open {} -> {}", url, why.to_string()),
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/ops/wints_search.rs#L73
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/ops/wints_search.rs:73:28
|
73 | false => open_urls(&options, urls),
| ^^^^^^^^ help: change this to: `options`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/ops/wints_search.rs#L72
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/ops/wints_search.rs:72:32
|
72 | true => urls_not_found(&options, module),
| ^^^^^^^^ help: change this to: `options`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/storage.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/storage.rs:99:40
|
99 | WintsStorage::store_module(&global_module.1, path)?;
| ^^^^^^^^^^^^^^^^ help: change this to: `global_module.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/storage.rs#L92
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/storage.rs:92:40
|
92 | WintsStorage::store_module(&local_module.1, path)?;
| ^^^^^^^^^^^^^^^ help: change this to: `local_module.1`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unnecessary `if let` since only the `Ok` variant of the iterator element is used:
src/wints/core/storage.rs#L55
warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
--> src/wints/core/storage.rs:55:9
|
55 | / for entry in glob::glob(
56 | | format!(
57 | | "{}/modules/*.yaml",
58 | | storage.global_basedir.as_path().display()
... |
71 | | }
72 | | }
| |_________^
|
help: remove the `if let` statement in the for loop and then...
--> src/wints/core/storage.rs:62:13
|
62 | / if let Ok(path) = entry {
63 | | let module_name = path
64 | | .file_stem()
65 | | .unwrap()
... |
70 | | storage.global_modules.insert(module_name, module);
71 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
help: try
|
55 ~ for entry in (glob::glob(
56 + format!(
57 + "{}/modules/*.yaml",
58 + storage.global_basedir.as_path().display()
59 + )
60 + .as_str(),
61 ~ )?).flatten() {
|
|
|
unnecessary `if let` since only the `Ok` variant of the iterator element is used:
src/wints/core/storage.rs#L36
warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
--> src/wints/core/storage.rs:36:9
|
36 | / for entry in glob::glob(
37 | | format!(
38 | | "{}/modules/*.yaml",
39 | | storage.local_basedir.as_path().display()
... |
52 | | }
53 | | }
| |_________^
|
help: remove the `if let` statement in the for loop and then...
--> src/wints/core/storage.rs:43:13
|
43 | / if let Ok(path) = entry {
44 | | let module_name = path
45 | | .file_stem()
46 | | .unwrap()
... |
51 | | storage.local_modules.insert(module_name, module);
52 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
= note: `#[warn(clippy::manual_flatten)]` on by default
help: try
|
36 ~ for entry in (glob::glob(
37 + format!(
38 + "{}/modules/*.yaml",
39 + storage.local_basedir.as_path().display()
40 + )
41 + .as_str(),
42 ~ )?).flatten() {
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/module.rs#L115
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/module.rs:115:79
|
115 | WintsModule::accuracy_of_matching_context(&matcher, &context, &second);
| ^^^^^^^ help: change this to: `second`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/module.rs#L113
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/module.rs:113:93
|
113 | let first_count = WintsModule::accuracy_of_matching_context(&matcher, &context, &first);
| ^^^^^^ help: change this to: `first`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/module.rs#L107
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/module.rs:107:83
|
107 | WintsModule::accuracy_of_matching_context(&matcher, &context, &element);
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/wints/core/module.rs#L87
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/wints/core/module.rs:87:83
|
87 | WintsModule::accuracy_of_matching_context(&matcher, &context, &element);
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
ci
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
ci
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|