Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty nose output #8

Merged
merged 1 commit into from
Jun 6, 2011
Merged

Conversation

oesmith
Copy link
Contributor

@oesmith oesmith commented Sep 10, 2010

Hi Roman,

I've implemented a couple of extra options for the nose plugin to pretty-print errors and undefined steps (essentially the same output as ConsoleHandler in handler.py produces, but for errors and undefined steps in the nose output).

Screenshots:

Output with --error-steps
Output with --list-undefined

It'd be great to see them pulled back into your repo.

Thanks,

Olly

…ed steps (--list-undefined) in the nose plugin.

Refactored pretty-printing code from handlers.py into prettyprint.py (for use in handlers.py _and_ noseplugin.py).

Two new features for --error-steps and --list-undefined.
@rlisagor
Copy link
Owner

Thanks for the patches! I will review and merge within the next few days.

@aleszoulek
Copy link
Contributor

+1 to this patch. I'd personally very appriciate prettier output.

Maybe we should unify the color theme and output style with my pull request, that adds freshen-list command, that prints all step definitions and file paths that are available for given feature file or directory of feature files.

See: http://github.com/rlisagor/freshen/pull/7

@oesmith
Copy link
Contributor Author

oesmith commented Sep 12, 2010

To keep the color theme and output style consistent with existing stuff in freshen, I refactored the colored output code from freshen/handlers.py:ConsoleHandler into freshen/prettyprint.py.

Do you think this would be usable for your freshen-list command too?

@rlisagor
Copy link
Owner

Hi Olly,

I had a chance to review your patch today. The code looks great. I would like to make a few small changes. I can't think of a reason to ever run without --error-steps, so it would be great to just make it non-optional. I will try to do this and merge this week. Sorry for the delay.

Roman.

@Enome
Copy link

Enome commented Apr 21, 2011

Did this ever get merged and Is freshen still being actively developed?

@oesmith
Copy link
Contributor Author

oesmith commented Apr 21, 2011

This hasn't been merged yet, but you can just use my repo for now if you really want these features.

I've not seen a lot of activity on this repo recently, but the code's pretty stable (we're still running hundreds of features through freshen every day and it's rock solid).

@rlisagor rlisagor merged commit dde4532 into rlisagor:master Jun 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants