Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to comply with symphony HTTPExceptionInterface #68

Merged

Conversation

bugzbrown
Copy link

issue

Error message when trying to use the user related endpoints:

Symfony\Component\ErrorHandler\Error\FatalError: Declaration of RLuders\JWTAuth\Exceptions\JsonValidationException::getStatusCode() must be compatible with Symfony\Component\HttpKernel\Exception\HttpExceptionInterface::getStatusCode(): int in /app/code/plugins/rluders/jwtauth/exceptions/JsonValidationException.php:12

fix

HTTPExceptionInterface in php 8> requires that the declaration contain types
This quick patch makes the JsonValidationException compatible to Symfony\Component\HttpKernel\Exception\HttpExceptionInterface again.

HTTPExceptionInterface
@rluders rluders merged commit 5ee88ce into rluders:main Aug 1, 2022
@rluders
Copy link
Owner

rluders commented Aug 1, 2022

Thanks, @bugzbrown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants