Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update xkbswitch-macosx README reference #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiehuc
Copy link
Contributor

@xiehuc xiehuc commented Jan 2, 2022

original xkbswitch-macosx's code is full of bug and hard to understand.

for eample:

  1. it use input source list index as an id, makes id differs on
    different machine
  2. it show layout by hard code it. just couldn't know why
  3. it couldn't set im.rime.inputmethod.Squirrel.Rime because it believes
    every sourceid has an com.apple prefix and hard code it.

so i modify it (copy from https://github.com/minoki/InputSourceSelector,
change api, which earlier and better)

original xkbswitch-macosx's code is full of bug and hard to understand.

for eample:

1. it use input source list index as an id, makes id differs on
   different machine
2. it show layout by hard code it. just couldn't know why
3. it couldn't set im.rime.inputmethod.Squirrel.Rime because it believes
   every sourceid has an com.apple prefix and hard code it.

so i modify it (copy from https://github.com/minoki/InputSourceSelector,
change api, which earlier and better)
@rlue
Copy link
Owner

rlue commented Jan 3, 2022

Interesting! I can appreciate all the effort you put in to modify InputSourceSelector's API, but my preference would be to avoid forks wherever possible.

What would you think if we modified vim-barbaric to add support for InputSourceSelector as well as xkbswitch, and use whichever one it finds on the user's $PATH? We could add code to vim-barbaric to support InputSourceSelector's API directly instead of adding a dependency to your fork, which could incur some maintenance burden in the long run.

@xiehuc
Copy link
Contributor Author

xiehuc commented Jan 11, 2022

you are right, i would do it when i have time.

i would also try pull request to original xkbswitch-macos to avoid fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants