Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test running ci in containers #2240

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Test running ci in containers #2240

wants to merge 8 commits into from

Conversation

ziyiwu9494
Copy link
Contributor

Test if we can simplify the CI a great deal by using the github actions container option

@ziyiwu9494 ziyiwu9494 requested a review from a team as a code owner February 20, 2021 00:54
@ziyiwu9494 ziyiwu9494 requested review from ryanjulian and removed request for a team February 20, 2021 00:54
@mergify mergify bot requested review from a team, zequnyu and yeukfu and removed request for a team February 20, 2021 00:55
container:
image: docker.pkg.github.com/${OWNER}/${DOCKER_CACHE_REPO}/${DOCKER_TAG}
credentials:
username: ${{ CI_USER }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably won't work either, but even if it did, it would have to be

Suggested change
username: ${{ CI_USER }}
username: ${{ env.CI_USER }}

@mergify mergify bot requested a review from a team February 20, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants