Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PoseTraining types #21

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Update PoseTraining types #21

merged 6 commits into from
Feb 27, 2024

Conversation

rly
Copy link
Owner

@rly rly commented Nov 22, 2023

Work in progress. This is a follow-up to #9 to get tests to pass and demonstrate plausible example usage code.

  • Update existing tests
  • Add unit tests for new types
  • Update README with test_example_usage.py
  • Touch base with ndx-pose users/developers to make sure the example code makes sense
  • Discuss how storage of training frames in a multi-camera setup should work
  • Update README with new contributors
  • Update how devices are handled based on Support linking to multiple camera devices #5 and original_videos should be a link #12

This PR introduces some major changes from the hierarchical organization in #9 in order to organize similar objects into the same group.

@rly rly marked this pull request as ready for review February 27, 2024 10:53
@rly
Copy link
Owner Author

rly commented Feb 27, 2024

Will merge now so that @talmo @eberrigan can hack on this to update TrainingFrame to hold embedded images and multiple skeleton instances.

@rly rly changed the title [WIP] Update PoseTraining types Update PoseTraining types Feb 27, 2024
@rly rly merged commit 232f614 into main Feb 27, 2024
@rly rly deleted the update_pose_training_group branch February 27, 2024 10:53
@talmo talmo mentioned this pull request Aug 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant