Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs say that maoni-email should be included but it's not #253

Closed
Ninjaman494 opened this issue Jul 12, 2021 · 4 comments
Closed

Docs say that maoni-email should be included but it's not #253

Ninjaman494 opened this issue Jul 12, 2021 · 4 comments

Comments

@Ninjaman494
Copy link

I was updating to 9.1.0 with the following dependencies in my build.gradle:

implementation 'org.rm3l:maoni:9.1.0@aar'
api 'org.rm3l:maoni-common:9.1.0@aar'

However, when I tried using Maoni builder to create a MaoniActivity I got a runtime error because MaoniEmailListener couldn't be found. I was able to fix it by adding org.rm3l:maoni-email:9.1.0 as a dependency, but in the README it says this should already be included?

@rm3l
Copy link
Owner

rm3l commented Apr 22, 2022

Hi @Ninjaman494 !

Thanks for reporting this issue. I was able to reproduce the issue and will look into it when I get a chance.
Thanks for the suggested workaround. I will update the README accordingly, until this issue is fixed.

maoni-email is correctly listed as a dependency of maoni, as we can see in its POM on Maven Central. So I think another possible workaround is to import maoni transitively with:

implementation('org.rm3l:maoni:9.1.0@aar') {
        transitive = true
        // Needed because of https://github.com/rm3l/maoni/issues/294
        exclude module: 'unspecified'
}

I just tested this successfully, but then came across this other weird issue (#294), hence the exclusion hacky rule.

@rm3l rm3l added the bug label Apr 22, 2022
rm3l added a commit that referenced this issue Apr 22, 2022
Importing each dependency non-transitively (as suggested in #253)
might require users to specify each dependency
indivifually, which might quickly feel cumbersome.

ref #253
ref #294
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

A friendly reminder that this issue had no activity for at least 90 days. Stale issues will be closed after an additional 30 days of inactivity.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

A friendly reminder that this issue had no activity for at least 90 days. Stale issues will be closed after an additional 30 days of inactivity.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue was closed because it has been inactive for 90 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants