Fix tried to close last window error #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easiest repro is only have a new buffer (not saved to a file) and exit. We'll try to close that window and generate an error. To fix, we wrap `Lib.close_unsupported_windows` in a `pcall`. In general, not great to eat all errors but we're making our best effort to close all of the unsupported windows and there are a bunch of edge cases there so this seems like the most reasonable path to me. Also added a missiing local
If we do close a window in a tab, keep checking other windows in that tab (that's why the `break` was removed). Log an error (debug level) if `close_unsupported_windows` fails. Only useful for debugging (not worth bothering the user about it)
rmagatti
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest repro is only have a new buffer (not saved to a file) and exit. We'll try to close that window and generate an error.
To fix, we wrap
Lib.close_unsupported_windowsin apcall. In general, not great to eat all errors but we're making our best effort to close all of the unsupported windows and there are a bunch of edge cases there so this seems like the most reasonable path to me.Also added a missiing local