Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search gui, node labels, and status filtering #194

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Add search gui, node labels, and status filtering #194

merged 4 commits into from
Jan 12, 2018

Conversation

karenhanson
Copy link
Contributor

@karenhanson karenhanson commented Jan 11, 2018 •
edited
Loading

This change consists of 3 major changes

  1. Added a basic search interface that uses the Solr index. Search is filterable by create date, agent, and status but defaults to status=active. Where the users searches for a specific URI and there is a match, the exact match will be displayed at the top of the search results.
  2. More meaningful node labels in graph visualizations. For DiSCO and Agent views, these are generated from within the DiSCO graph. For Resource views, these are generated using the index. In both instances, a configurable list of label types is used to determine possible labels. This closes issue Simplify node labels on visualization. #68.
  3. Support for toggling of status filter on resources views. This closes issue When Resource Summary only has inactive statements get Resource Not Found #97 but has also been implemented in a way that will support other filter toggles in the future (e.g. toggling agent filters)

Change includes basic tests for this new functionality.

@karenhanson
Search form and results page in webapp
c59b0c0 
- Initial search results page, needs tests.
- Removed original search form and replaced with one that uses GET. All filters/searches use GET so that the URL can be bookmarked
- Includes filters for status, date, and agent
@karenhanson
Add node labels, add support for status filter on all data views
3c95480 
- use search index to create meaningful node labels
- refactored graph model to support new labels
- add label to top of resource summary page
- add ability to filter by status on all views (incomplete) - this is to resolve a problem where you can only see active statements on Resource Summary, but in future could be used to toggle agent filters and other things on Resource view.
@karenhanson
GUI changes to support status filter
d833516 
back end was already configured, this adds a checkbox to toggle status
on and off, and shows messages/tooltips to prompt people to show
inactive.
@karenhanson
Added more webapp search gui tests, improved existing tests
48fd615 
Added basic tests for new search and label functionality.
For existing tests, shifted them to depend on mocks rather than embedded solr, where possible.
Rearranged and improved TestUtils.
@karenhanson karenhanson requested a review from emetsger January 11, 2018 14:29
@emetsger emetsger merged commit b5c871c into rmap-project:master Jan 12, 2018
@karenhanson karenhanson deleted the webapp-solr-search branch January 12, 2018 15:12
This was referenced Jan 12, 2018
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emetsger emetsger Awaiting requested review from emetsger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenhanson @emetsger