refactor pysift as a library with install #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@normanb Wow, thanks a lot! This is extremely helpful. Yes, I'm very interested in this PR, and please by all means expand further. Truth be told, I don't have too much time these days, but if I can help you out somehow, please let me know. |
|
@rmislam thank you. I am going to make the library callable by breaking out the functions where I can and so that the code can be ran in parallel to increase performance. I can work in this branch with separate commits so you can clearly see the changes. I understand that the code needs to be readable enough for people following your tutorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rmislam As I was working through the code I refactored the library slightly and added a packaging script (
setup.py). If you are interested in this PR then I can expand further and add tox for testing as well as refactoring the code a little to include more testing and modularity.Thank you for writing this and the excellent tutorial on the SIFT algorithm.