Zero-width space doesn't result in nil after stripping #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aried3r
commented
Feb 13, 2020
| @@ -124,6 +128,8 @@ def test_should_strip_all_fields | |||
| assert_equal "fiz \n fiz", record.fiz | |||
| assert_nil record.baz | |||
| assert_nil record.bang | |||
| assert_nil record.qax | |||
| assert_nil record.qux | |||
There was a problem hiding this comment.
Failure:
StripAttributesTest#test_should_strip_all_fields [/home/travis/build/rmm5t/strip_attributes/test/strip_attributes_test.rb:132]
Minitest::Assertion: Expected "" to be nil.
|
Good catch. I'd agree that the existing behavior is a problem and your desired test is the correct behavior. I'll try to fix this shortly. |
|
@aried3r Thank you for this. v1.9.1 is now released with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a question instead of a PR. While using this gem in our codebase we discovered that while strings like
"\n\t\ "result innil,"\u200B"results in the empty string. Is this intended behavior?You can see the failing test in this PR.