Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging #23

Open
rmnldwg opened this issue Dec 14, 2021 · 2 comments
Open

Logging #23

rmnldwg opened this issue Dec 14, 2021 · 2 comments
Assignees
@rmnldwg
Labels
code quality Improvements w.r.t. readability of code & best practices of coding feature New feature or request

Comments

@rmnldwg
Copy link
Owner

rmnldwg commented Dec 14, 2021

Implement some logging for more feedback while using the package.
@rmnldwg rmnldwg added documentation Improvements or additions to documentation feature New feature or request labels Dec 14, 2021
@rmnldwg rmnldwg self-assigned this Dec 14, 2021
@rmnldwg rmnldwg added wontfix This will not be worked on code quality Improvements w.r.t. readability of code & best practices of coding and removed documentation Improvements or additions to documentation labels Aug 2, 2022
@rmnldwg
Copy link
Owner Author

rmnldwg commented Aug 2, 2022

Not sure this makes a lot of sense, since the package can't be executed on its own. One always has to write code using this library, so logging can - and probably should - be implemented at that point.

rmnldwg added a commit that referenced this issue Aug 10, 2023
@rmnldwg
feat: add best-practice logging setup
2ad4162 
Related: #23
@rmnldwg rmnldwg removed the wontfix This will not be worked on label Dec 29, 2023
@rmnldwg
Copy link
Owner Author

rmnldwg commented Dec 29, 2023

It does make sense and I implemented a basic logging setup and some first logging statements here and there.

For example, the __init__.py of my package now has a minimal logging setup inspired by urllib3's logging setup. This way, anyone who is using my library within some other framework or tool may simply turn on the lymph package's logging via the provided function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmnldwg rmnldwg

Labels
code quality Improvements w.r.t. readability of code & best practices of coding feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmnldwg