GraphiQL broken in production. Duplicate "graphql" modules. #58

a-barbieri · 2018-11-22T10:22:40Z

We are using graphiql-rails as a dependency on one our gems.

From version 1.5 the graphiql page is broken. I can confirm that 1.4.11 along with graphql 1.8.10 works.

The error is present only in production environment. Development works. Might be something that happens during the assets precompile process.

Bug

Accessing GraphiQL page I see only the loading... message and get this error:

Uncaught Error: Cannot use t "__Schema" from another module or realm.

Ensure that there is only one instance of "graphql" in the node_modules
directory. If different versions of "graphql" are the dependencies of other
relied on modules, use "resolutions" to ensure only one version is installed.

https://yarnpkg.com/en/docs/selective-version-resolutions

Duplicate "graphql" modules cannot be used at the same time since different
versions may have different capabilities and behavior. The data from one
version used in the function from another could produce confusing and
spurious results.

Which then create a second obvious error:

Uncaught ReferenceError: GraphiQL is not defined

The text was updated successfully, but these errors were encountered:

gregology · 2018-12-02T14:34:20Z

I'm also having this issue. The error is not occurring in development, only in production.

gem 'graphql',                      '~> 1.8.11'
gem 'graphiql-rails',               '~> 1.5.0'

zeroedin · 2018-12-11T15:10:35Z

Having the same issue, staging env, not production, but similar as in not a development env.

graphql (1.8.11)
graphiql-rails (1.5.0)

denisahearn · 2018-12-13T17:41:33Z

We also started having this issue in our staging environment once we upgraded to:

graphql (1.8.11)
graphiql-rails (1.5.0)

marckohlbrugge · 2019-01-08T16:44:14Z

Same problem, using these gems:

graphql (1.8.11)
graphiql-rails (1.5.0)

eric-khoury · 2019-01-17T17:47:06Z

Same issue here:

Using graphql 1.8.13
Using graphiql-rails 1.5.0

wadewinningham · 2019-01-24T20:26:52Z

I have this issue, but it's in development.

graphiql-rails (1.6.0)
graphql-pro (1.9.5)

Works with graphiql-rails 1.4.11, but I'm getting the error reported here in both 1.5.0 and 1.6.0.

leechunhoe · 2019-01-29T10:09:30Z

graphiql-rails 1.6.0, graphql 1.8.11 works okay in development, but shows following error when build production.

Uglifier::Error: In strict mode code, functions can only be declared at top level or immediately within another function.
/var/app/current/vendor/bundle/ruby/2.5.0/gems/uglifier-4.1.20/lib/uglifier.rb:234:in `parse_result'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/uglifier-4.1.20/lib/uglifier.rb:216:in `run_uglifyjs'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/uglifier-4.1.20/lib/uglifier.rb:168:in `compile'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/uglifier_compressor.rb:53:in `call'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/uglifier_compressor.rb:28:in `call'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/processor_utils.rb:75:in `call_processor'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/processor_utils.rb:57:in `block in call_processors'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/processor_utils.rb:56:in `reverse_each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/processor_utils.rb:56:in `call_processors'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/loader.rb:134:in `load_from_unloaded'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/loader.rb:60:in `block in load'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/loader.rb:317:in `fetch_asset_from_dependency_cache'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/loader.rb:44:in `load'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/cached_environment.rb:20:in `block in initialize'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/cached_environment.rb:47:in `load'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/base.rb:66:in `find_asset'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/base.rb:73:in `find_all_linked_assets'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/manifest.rb:142:in `block in find'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/legacy.rb:114:in `block (2 levels) in logical_paths'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:228:in `block in stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:212:in `block in stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:227:in `stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:231:in `block in stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:212:in `block in stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:227:in `stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:231:in `block in stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:212:in `block in stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:209:in `stat_directory'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/path_utils.rb:227:in `stat_tree'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/legacy.rb:105:in `each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/legacy.rb:105:in `block in logical_paths'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/legacy.rb:104:in `each'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/legacy.rb:104:in `logical_paths'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/manifest.rb:140:in `find'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/sprockets/manifest.rb:186:in `compile'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-rails-3.2.1/lib/sprockets/rails/task.rb:68:in `block (3 levels) in define'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-3.7.2/lib/rake/sprocketstask.rb:147:in `with_logger'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/sprockets-rails-3.2.1/lib/sprockets/rails/task.rb:67:in `block (2 levels) in define'
/var/app/current/vendor/bundle/ruby/2.5.0/gems/rake-12.3.2/exe/rake:27:in `<top (required)>'
/usr/local/bin/bundle:30:in `block in <main>'
/usr/local/bin/bundle:22:in `<main>'
Tasks: TOP => assets:precompile
(See full trace by running task with --trace)

mortik · 2019-01-29T10:18:14Z

@leechunhoe you need to update your production environment and set your js_compressor like this:

config.assets.js_compressor = Uglifier.new(harmony: true)

Don't forget to require 'uglifier'

Concerning the Topic:
1.6.x is still causing the initial mentioned Bug in Production for me.

gregology · 2019-01-29T17:53:13Z

Forgive my ignorance but will updating to production React fix this issue?

mortik · 2019-01-29T18:05:54Z

No this fixes only the issue @leechunhoe posted

gregology · 2019-01-29T18:10:10Z

Sorry @mortik, I was referring to PR #61, not the updates to production environment you suggested above. I'd try it out but I don't have a production app that I can risk breaking atm :(

mortik · 2019-01-29T18:26:15Z

Ah no problem i only read the notification mail which did not include the link ^^

leechunhoe · 2019-01-30T09:17:48Z

Thank you @mortik, the errors fixed. Though graphiql still won't load on production.

mortik · 2019-01-30T09:27:43Z

yeah sadly still need to set 'graphiql-rails', '~> 1.4.11'

gregology · 2019-01-31T22:55:51Z

~~It looks like #61 has fixed the issue. 1.7.0 now works for me 👍~~

gem 'graphql',                      '~> 1.8.13'
gem 'graphiql-rails',               '~> 1.7.0'

mortik · 2019-02-01T09:39:33Z

hmm upgraded to 1.7 did not change the error for me.

gregology · 2019-02-04T15:55:04Z

Yes, disregard, it was just a slow propagation issue. Sorry if anyone deployed. Back to 1.4.11

gregology · 2019-02-04T18:09:11Z

Is everyone with this issue running production on Google Cloud Platform?
👍 for yes 👎 for no
I'm not sure if GCP is respecting NODE_ENV: production from the app.yaml file when precompiling assets. I was following advice from howtographql/react-apollo#33 (comment)

wadewinningham · 2019-02-04T22:13:43Z

The update did not fix my issue either, but I'm not sure if graphql-pro is behind.

isaacrowntree · 2019-02-20T04:36:29Z

Still not fixed (not on GCP):

gem 'graphql', '~> 1.8.13'
gem 'graphql-client', '~> 0.14.0'
gem 'graphql-errors', '~> 0.3.0'
gem 'graphiql-rails', '~> 1.7'

xiaocuixt · 2019-02-22T10:33:26Z

Just Worked with the old version 😭 :

    gem 'graphql', '~> 1.9.2'
    gem 'graphiql-rails', '~> 1.4.11'

G-shuu · 2019-03-04T07:00:24Z

for me same issue

graphiql-rails (1.5.0)
graphql (1.8.13)

saiidalhalawi · 2019-04-09T06:47:43Z

The same issue has occurred on Heroku.

graphiql-rails (1.7.0)
graphql (1.9.3)

GraphiQL web UI is not working on staging/production. Downgrading should fix this. rmosolgo/graphiql-rails#58

rmosolgo/graphiql-rails#58

davelooi · 2019-05-06T03:21:49Z

This has been happening since Nov 2018.
Does anyone has a workaround for this? Other than locking to 1.4.

Is there a plan to fix this in the future? Anything we can do to help?

mortik · 2019-05-06T05:22:24Z

We removed graphiql-rails from our Apps and are now using a html only version of the GraphiQL Playground from Prisma https://github.com/prisma/graphql-playground

The next step would be to use the React Component to build a customized Playground with Subscription support like you would get when you use Apollo Server or Absinthe from Elixir but in this case for Rails with ActionCable

blevine · 2019-05-28T20:34:07Z

I am seeing the same issue. Anyone have a fix?

eric-khoury · 2019-05-28T23:43:06Z

@mortik In that case, have you tried Altair?
No integration within the app, just connect directly to any graphql endpoint, has subscriptions, etc.

aperaham · 2019-07-02T23:33:09Z

In my case, the issue involved Uglifier mangling variables in the javascript file. The following settings appear to work:

config.assets.js_compressor = Uglifier.new(harmony: true, mangle: false)

Make sure to update Uglifier to a version that supports the mangle option.

jessecurry · 2019-07-17T22:28:07Z

I'm experiencing this issue on Heroku and have been able to duplicate locally in production mode. Using mangle: false did not resolve my issue.

Is there a long term fix in the works?

stanhu · 2019-09-11T22:17:13Z

We just came across this in GitLab as well (https://gitlab.com/gitlab-org/gitlab-ce/issues/67293).

As described in graphql/graphql-js#1182 (comment):

So, as far as I can see the problem is that GraphQLScalarType and GraphQLObjectType constructors both get e as a shortcut during the minifying. And when graphql-js tries to compare them — condition is true and it throws an error.

Disabling name mangling in UglifyJsPlugin via mangle: false sounds like a possible workaround, but this may bloat the size of the JavaScript output.

graphql-js added a fix to disable this check when NODE_ENV is set to production (graphql/graphql-js#1174).

Normally, Webpack will set NODE_ENV properly and generate assets accordingly. However, if you are using Sprockets, NODE_ENV is never set to anything, so this check always gets hit if name mangling is in use.

Perhaps this gem is no longer needed now that Rails 5 defaults to Webpacker (https://github.com/rails/webpacker). For those of us not using Webpacker, I wonder if we can work around this by defining a NODE_ENV inside or patching the graphql-js code during asset compilation.

mcelicalderon · 2019-09-25T18:00:40Z

I did not try mangle: false, but problem persists on v1.7.0 using the harmony: true option on Uglifier. I just went ahead and downgraded to v1.4.11 of this gem as @a-barbieri originally pointed out that works. Kept harmony: true option

marckohlbrugge · 2019-10-15T13:18:16Z

Since the gem doesn't seem to maintained anymore, does anyone have successfully implemented graphiql using webpacker?

yask123 · 2019-11-12T19:42:12Z

We stopped using this gem and just directly use graphiql-js library.

duffyjp · 2019-12-30T16:04:13Z

@yask123 Can you give some pointers on how you did that? I'm in the same boat.

nsikanikpoh · 2020-03-10T07:12:09Z

Just Worked with the old version :
    gem 'graphql', '~> 1.9.2'
    gem 'graphiql-rails', '~> 1.4.11'

This works for me as well Thanks

michaelbina · 2020-06-09T21:43:46Z

For anyone else that gets here, the combination of

config.assets.js_compressor = Uglifier.new(harmony: true, mangle: false)

and

gem 'graphql'
gem 'graphiql-rails', '~> 1.5.0'

worked for me

andrew-gregory-genedx · 2021-06-21T22:06:35Z

gem 'graphql', ~> '1.11.4'
gem 'graphql-rails', ~> '1.4.11'

worked for me. gem 'graphql-rails', ~> '1.5.0' did not work.

I believe this root issue is also solved by this PR in graphql-js.

The error I was getting was the same, except e "__Schema", not t "__Schema".

rmosolgo · 2024-02-23T19:35:56Z

Hey everyone, I hope that upstream fixes and new configurations for the minifier worked alright. If anyone runs into this again, please open a new issue!

a-barbieri mentioned this issue Nov 22, 2018

GraphiQL broken in production. Duplicate "graphql" modules. BindaCMS/binda-api#11

Closed

swelther mentioned this issue Nov 22, 2018

1.5.0 not working in production environment #59

Closed

camallen mentioned this issue Apr 10, 2019

Graphql UI isn't available zooniverse/panoptes#3111

Closed

anandaroop added a commit to anandaroop/portfolio18 that referenced this issue Apr 20, 2019

Downgrade graphiql-rails

7d6aaff

GraphiQL web UI is not working on staging/production. Downgrading should fix this. rmosolgo/graphiql-rails#58

jamescmartinez added a commit to coffeecoffeecoffeecoffee/coffee that referenced this issue Apr 27, 2019

Downgrade GraphiQL so it works in production

47a7abb

rmosolgo/graphiql-rails#58

thesecretmaster mentioned this issue Dec 31, 2019

Broken link to GraphQL Data Exploder Charcoal-SE/metasmoke#690

Closed

ogidow mentioned this issue Nov 26, 2020

Upgrade GraphiQL #89

Closed

rmosolgo closed this as completed Feb 23, 2024

GraphiQL broken in production. Duplicate "graphql" modules. #58

GraphiQL broken in production. Duplicate "graphql" modules. #58

Comments

a-barbieri commented Nov 22, 2018

Bug

gregology commented Dec 2, 2018

zeroedin commented Dec 11, 2018

denisahearn commented Dec 13, 2018

marckohlbrugge commented Jan 8, 2019

eric-khoury commented Jan 17, 2019

wadewinningham commented Jan 24, 2019

leechunhoe commented Jan 29, 2019

mortik commented Jan 29, 2019 • edited Loading

gregology commented Jan 29, 2019

mortik commented Jan 29, 2019

gregology commented Jan 29, 2019 • edited Loading

mortik commented Jan 29, 2019

leechunhoe commented Jan 30, 2019

mortik commented Jan 30, 2019

gregology commented Jan 31, 2019 • edited Loading

mortik commented Feb 1, 2019

gregology commented Feb 4, 2019 • edited Loading

gregology commented Feb 4, 2019 • edited Loading

wadewinningham commented Feb 4, 2019

isaacrowntree commented Feb 20, 2019

xiaocuixt commented Feb 22, 2019 • edited Loading

G-shuu commented Mar 4, 2019 • edited Loading

saiidalhalawi commented Apr 9, 2019

davelooi commented May 6, 2019

mortik commented May 6, 2019

blevine commented May 28, 2019

eric-khoury commented May 28, 2019

aperaham commented Jul 2, 2019

jessecurry commented Jul 17, 2019

stanhu commented Sep 11, 2019 • edited Loading

mcelicalderon commented Sep 25, 2019

marckohlbrugge commented Oct 15, 2019

yask123 commented Nov 12, 2019

duffyjp commented Dec 30, 2019

nsikanikpoh commented Mar 10, 2020 • edited Loading

michaelbina commented Jun 9, 2020

andrew-gregory-genedx commented Jun 21, 2021

rmosolgo commented Feb 23, 2024

mortik commented Jan 29, 2019 •

edited

Loading

gregology commented Jan 29, 2019 •

edited

Loading

gregology commented Jan 31, 2019 •

edited

Loading

gregology commented Feb 4, 2019 •

edited

Loading

gregology commented Feb 4, 2019 •

edited

Loading

xiaocuixt commented Feb 22, 2019 •

edited

Loading

G-shuu commented Mar 4, 2019 •

edited

Loading

stanhu commented Sep 11, 2019 •

edited

Loading

nsikanikpoh commented Mar 10, 2020 •

edited

Loading