Allow libgraphql parser to optionally be built with cmake

[ianks]

Manually installing graphql is a big burden for entry for using this gem. It takes time, manual effort, and we can't ensure the version of libgraphql parser is compatible.

Many users already have cmake and a modern c++ compiler installed on their system. As a result, we can compile libgraphql in the gem install process. This makes installing the gem a breeze for many users.

If they do not have cmake, or something goes wrong, we just fall back to the old method of looking up the library. Thus, this PR does not affect users which do not have cmake.

[rmosolgo]

Wow, impressivel! Looks good to me.

I guess since Travis is green, and isn't making a manual install, we can assume it's using the bundled-in version, right?

[rmosolgo]

Oops, did this sneak in somehow?

[ianks]

yup! fixed!

[ianks]

we can assume it's using the bundled-in version, right

Yup! Travis is no longer installing libgraphqlparser anymore. It comes from the bundled gem.

[ianks]

@rmosolgo Any thing else needed for this?

[rmosolgo]

This looks great, thanks for the bump!

[rmosolgo]

Taking a try locally and hitting:

/Users/rmosolgo/code/graphql-libgraphqlparser-ruby/lib/graphql/libgraphqlparser.rb:5:in `require_relative': dlopen(/Users/rmosolgo/code/graphql-libgraphqlparser-ruby/lib/graphql_libgraphqlparser_ext.bundle, 9): Library not loaded: libgraphqlparser.dylib (LoadError)
  Referenced from: /Users/rmosolgo/code/graphql-libgraphqlparser-ruby/lib/graphql_libgraphqlparser_ext.bundle
  Reason: image not found - /Users/rmosolgo/code/graphql-libgraphqlparser-ruby/lib/graphql_libgraphqlparser_ext.bundle
	from /Users/rmosolgo/code/graphql-libgraphqlparser-ruby/lib/graphql/libgraphqlparser.rb:5:in `<top (required)>'
	from /Users/rmosolgo/code/graphql-libgraphqlparser-ruby/test/test_helper.rb:2:in `require'
	from /Users/rmosolgo/code/graphql-libgraphqlparser-ruby/test/test_helper.rb:2:in `<top (required)>'

It seems like libgraphqlparser/build/lib/libgraphqlparser.dylib isn't being found at runtime... hmm...

[ianks]

Interesting. Full disclosure, I developed this on linux and did not test on a mac. let me take a look and see if i can get it working on a mac.

[ianks]

@rmosolgo I figured out the issue. Essentially we need to use install_name_tool to fix the path for libgraphqlparser.dylib. I do not have a mac so this is hard to test, but maybe someone can give it a whirl? should be easy. If not, I can attempt it when I get around a mac at some point.

http://thecourtsofchaos.com/2013/09/16/how-to-copy-and-relink-binaries-on-osx/

[lucaspolonio]

Hey @rmosolgo, I see this has been merged but no new release has been created since then. Do you plan to create a new release that includes this change?

[rmosolgo]

Sorry, I got hung up trying to run it locally and haven't tried again! It looks like there's a lead above, but I want to be able to run the tests locally before releasing a version. Do you want to take a crack at it?

[rmosolgo]

opened a proper issue here: #25

[rmosolgo]

Sorry, I ended up reverting this in 5fe220a :'(

I would love to include a bundled copy of libgraphqlparser but I couldn't get past the issue described in #25.

I think the next step is to get a travis build on OSX and make sure that passes