Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Abstract Types - note about resolve_type #1247

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Jan 29, 2018

This PR adds wording to the UnionType resolve_type docs, so that new users do not remove the resolve_type function from their Schema.

This is linguistic nudging.

  - added wording which indicates that the schema-level function is still used
@olleolleolle
Copy link
Contributor Author

Here's an Issue reported which noted that this is "how things behave": #1205

@rmosolgo
Copy link
Owner

Yes, better to have correct docs while that bug goes unfixed. Thanks for the improvement!

@rmosolgo rmosolgo merged commit c43198d into rmosolgo:master Jan 29, 2018
@olleolleolle olleolleolle deleted the patch-1 branch January 29, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants