Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NO_TYPED_CHILDREN compatibility #1277

Merged
merged 3 commits into from
Feb 13, 2018
Merged

Fix NO_TYPED_CHILDREN compatibility #1277

merged 3 commits into from
Feb 13, 2018

Conversation

rmosolgo
Copy link
Owner

My wacky object in 1.7.10 was a bit broken, this is a simpler and better solution which is just as fast.

I used be rake bench:validate to confirm that performance is the same.

@swalkinshaw
Copy link
Collaborator

👏

@rmosolgo rmosolgo added this to the 1.7.11 milestone Feb 13, 2018
@rmosolgo rmosolgo merged commit f97b4d2 into master Feb 13, 2018
@rmosolgo rmosolgo deleted the special-hash branch February 13, 2018 20:42
@rmosolgo
Copy link
Owner Author

Ug, this was still wrong, it should be {}.freeze not [].freeze

@rmosolgo rmosolgo mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.11
Development

Successfully merging this pull request may close these issues.
2 participants
@rmosolgo @swalkinshaw